Disable test-android-template on PR
#44865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58394745 |
|
This pull request was exported from Phabricator. Differential Revision: D58394745 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44865 This has not yet passed on main since we started testing on main two weeks ago: https://github.com/facebook/react-native/actions/runs/9316380994/job/25688028045 This change disables the GitHub Actions version `test_android_template` as a signal for PRs or diffs, since it isn't stable yet (but we still run it on main, and can manually dispatch it on any branch). This coverage is still enabled in CircleCI. Changelog: [Internal] Differential Revision: D58394745
NickGerleman
force-pushed
the
export-D58394745
branch
from
e289a06
to
f0ad153
Compare
Summary: Pull Request resolved: facebook#44865 This has not yet passed on main since we started testing on main two weeks ago: https://github.com/facebook/react-native/actions/runs/9316380994/job/25688028045 This change disables the GitHub Actions version `test_android_template` as a signal for PRs or diffs, since it isn't stable yet (but we still run it on main, and can manually dispatch it on any branch). This coverage is still enabled in CircleCI. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D58394745
|
This pull request was exported from Phabricator. Differential Revision: D58394745 |
NickGerleman
force-pushed
the
export-D58394745
branch
from
f0ad153
to
4b14568
Compare
Base commit: 5b3a321 |
|
This pull request has been merged in db0e9ea. |
|
This pull request was successfully merged by @NickGerleman in db0e9ea. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This has not yet passed on main since we started testing on main two weeks ago: https://github.com/facebook/react-native/actions/runs/9316380994/job/25688028045
This change disables the GitHub Actions version
test_android_templateas a signal for PRs or diffs, since it isn't stable yet (but we still run it on main, and can manually dispatch it on any branch). This coverage is still enabled in CircleCI.Changelog: [Internal]
Differential Revision: D58394745